Revert "refactor: retire sketch-core mirror (#307)"#310
Merged
Conversation
This reverts commit ba0cfce.
zzylol
added a commit
that referenced
this pull request
May 2, 2026
zzylol
added a commit
that referenced
this pull request
May 2, 2026
After PR #307 was admin-merged with a failing test (and then reverted in PR #310), redo the consumer migration cleanly with two follow-up changes: 1. Drop the \`branch = "refactor/adopt-sketch-core-modules"\` pin from asap-query-engine/Cargo.toml. asap_sketchlib#36 is on main as commit \`d22a9ab\`; the consumer now tracks the default branch. 2. Loosen the \`test_esdsl_time_range_query\` assertion to ±1 tolerance. The test computed P90 of 200..300 from a KLL and asserted exactly 291; asap_sketchlib's KLL reports 290 on this distribution, which is within KLL's published rank-error bound but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired with sketch-core). Tests: - \`cargo test -p query_engine_rust --lib precompute_operators\` → 87 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic\` → 15 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query\` → passes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
May 2, 2026
After PR #307 was admin-merged with a failing test (and then reverted in PR #310), redo the consumer migration cleanly with two follow-up changes: 1. Drop the \`branch = "refactor/adopt-sketch-core-modules"\` pin from asap-query-engine/Cargo.toml. asap_sketchlib#36 is on main as commit \`d22a9ab\`; the consumer now tracks the default branch. 2. Loosen the \`test_esdsl_time_range_query\` assertion to ±1 tolerance. The test computed P90 of 200..300 from a KLL and asserted exactly 291; asap_sketchlib's KLL reports 290 on this distribution, which is within KLL's published rank-error bound but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired with sketch-core). Tests: - \`cargo test -p query_engine_rust --lib precompute_operators\` → 87 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic\` → 15 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query\` → passes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
milindsrivastava1997
pushed a commit
that referenced
this pull request
May 4, 2026
…est fix (#309) * Revert "Revert "refactor: retire sketch-core mirror (#307)" (#310)" This reverts commit ea723f4. * chore: track asap_sketchlib main + fix elastic DSL quantile assert After PR #307 was admin-merged with a failing test (and then reverted in PR #310), redo the consumer migration cleanly with two follow-up changes: 1. Drop the \`branch = "refactor/adopt-sketch-core-modules"\` pin from asap-query-engine/Cargo.toml. asap_sketchlib#36 is on main as commit \`d22a9ab\`; the consumer now tracks the default branch. 2. Loosen the \`test_esdsl_time_range_query\` assertion to ±1 tolerance. The test computed P90 of 200..300 from a KLL and asserted exactly 291; asap_sketchlib's KLL reports 290 on this distribution, which is within KLL's published rank-error bound but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired with sketch-core). Tests: - \`cargo test -p query_engine_rust --lib precompute_operators\` → 87 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic\` → 15 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query\` → passes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #307. PR #307 was admin-merged with a failing CI test (
tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query— quantile mismatch290 vs 291). Reverting + reopening as a combined PR with the cleanup from #309 and a fix for the test.